Lars Grüter

Results 496 comments of Lars Grüter

@decorouz do you mind if I move this to the `skimage.future` module or do you want to give it a try? :)

The [CI failure](https://dev.azure.com/scikit-image/scikit-image/_build/results?buildId=11173&view=logs&j=5b382255-19bb-59b2-9a36-539f25119b1b&t=41245e71-1633-5278-7581-af00eac25284&l=1107) is due to a warning while building the docs on Windows. Not sure why that's showing up, but it seems completely unrelated to this.

@decorouz, @mkcor I made another pass at the gallery example and docstrings. I've put it through https://languagetool.org and also tried to improve the clearness in a few places, especially the...

Ready to merge if the CI is green! :rocket:

Wooh! :tada: Thank you @decorouz, @ana42742 and everyone else who was involved in this Outreachy project and PR! :blush:

Hey @prajwel, thanks for the suggestion! :) At a first glance this sounds sensible. Though, as far as I can see we'd have to implement Arun / Horns algorithm if...

Thanks for the suggestion @ana42742! I'll try to look into this tomorrow. Otherwise don't be afraid to ping me if I forget. :sweat_smile:

Hey , I'm no expert in the topic and my background is not in image processing, but... on the surface this looks like something worth investigating. From what I gather...

> Is it even possible for a skimage function to call a C program? Yes, we use a lot of C/C++ or Cython-based code in scikit-image (e.g. have a look...

I am not familiar at all with algorithm and implementation but this lines https://github.com/scikit-image/scikit-image/blob/441fe68b95a86d4ae2a351311a0c39a4232b6521/skimage/metrics/_structural_similarity.py#L169-L175 https://github.com/scikit-image/scikit-image/blob/441fe68b95a86d4ae2a351311a0c39a4232b6521/skimage/metrics/_structural_similarity.py#L222-L228 seem relevant. Regardless of `gaussian_weights`, `win_size` might affect the result via `cov_norm` if `use_sample_covariance=True`. I...