Lars Grüter

Results 496 comments of Lars Grüter

Hey @orena1, thank you very much for the patch! Do I understand you correctly? `_exclude_borders` is supposed to ensure that the supplied input to the `exclude_borders` parameter is turned into...

@orena1 thanks for the fast response! I've left a suggestion to make the test's a bit less repeating and to cover `blob_log` as well. Otherwise this looks almost ready to...

> Something like this: That suggestion seems totally fine to me except for this line: ```python assert b[0] == disk_center[0] if type(disk_center) == int else disk_center[0],

Hey @newcomertzc, thank you for the suggested improvement! From looking at the code and reading the docstring, I'm not sure that the the scaling operation with a power of two...

Ah, thank you @newcomertzc for the detailed explanation. The Poisson is discrete so we need to scale lambda up so that we get a reasonable resolution of the Poisson distribution....

> I think it's "weird" for a 256-color image to have 257 unique values. But it is not a 256-color (or 8-bit) image I think? It is the result of...

@TimMcCauley, sorry for the small delay in responses. I'll look into this next week if nobody more familiar with the problem picks this up. In the meantime thank you for...

Hey @lucas-johnson, thank your for the detailed issue and I'm sorry for the late response on this. It seems this has fallen through the cracks. I'm not yet familiar with...

@modaresimr thanks for reporting what looks like a bug to me currently? I can reproduce this with our current `main`. There is something really interesting going on: ```python import numpy...

This persists even when switching the order of the dimensions for the input image. @ev-br, as one of the most "recent" contributors to `skeletonize`'s underlying Cython function `_compute_thin_image`, maybe the...