Lars Grüter

Results 496 comments of Lars Grüter

Okay, it tries to build again but fails. I am not sure whether this is the source of the failure but we get a lot of > performance hint: /home/jovyan/skimage/graph/heap.pyx:580:33:...

I don't think the `noexcept` warning is the culprit.

Related https://github.com/scikit-image/scikit-image/pull/7250

Ha, fixing the warning in https://github.com/scikit-image/scikit-image/pull/7250 seems to have fixed the build problems. See [https://mybinder.org/v2/gh/**lagru/scikit-image/cython30-noexcept**?filepath=notebooks/auto_examples/edges/plot_convex_hull.ipynb](https://mybinder.org/v2/gh/lagru/scikit-image/cython30-noexcept?filepath=notebooks/auto_examples/edges/plot_convex_hull.ipynb). So this should hopefully work again for the next release.

Binder can be configured to use tags instead of branches as the target in the documentation ([sphinx-gallery config](https://sphinx-gallery.github.io/stable/configuration.html#binder-links)). That would allow us to skip creating a branch. However, this also...

E.g. see https://github.com/scikit-image/scikit-image/actions/runs/5271158822/jobs/9531640440?pr=7021#step:6:1060.

https://github.com/scikit-image/scikit-image/actions/runs/5289760544/jobs/9573082472#step:6:943

> How is this different from what we publish in the API reference guide? Basically, I view this as a very useful tool and start to inspect our API. This...

> If we can figure out how this can be generally useful, we can host it under scientific-python. Happy to do so. I can already apply this to SciPy, NumPy,...

Wow, griffe looks very cool! Thanks for recommending it. I wasn't able to find any of these tools when I checked but should have known that I was reinventing the...