Florian Rathgeber

Results 121 comments of Florian Rathgeber

Can you confirm what your setup is? Are you using the `pre-commit` framework with a `.pre-commit-config.yaml` as documented in the [README](https://github.com/kynan/nbstripout#using-nbstripout-as-a-pre-commit-hook)? A reproducible test case would also be super useful....

I think this is similar to #121. See my [comment](https://github.com/kynan/nbstripout/issues/121#issuecomment-817388175) with the log of a test which produced the exact result I expected, using pre-commit 2.12.0.

@krlng is this still an issue for you?

Yes, that seems to be the intended behaviour of `pre-commit`: the idea is that the hook will fail if it would be changing the content since that means that the...

@nix1 any update on this? Feel free to close if you consider this resolved.

I think you'd need to stage all the changes the hook made before running it again. Otherwise it'll fail again in the same way.

Any update on this @nix1 @VikashKothary ? I've tried reproducing this behavior with a simple test: 1. commit stripped notebook with 1 code cell 2. add another code cell, run...

@nix1 @VikashKothary is this still an issue for you?

Thanks for investigating @LukaPitamic @IsabellLehmann! If this issue is resolved for you both, can we close it?