Florian Rathgeber

Results 121 comments of Florian Rathgeber

That's even better, as people don't read documentation :)

> all files are always printed as if they would be changed Can you clarify what you mean? What are "all files" here?

OK, I see what you mean. It is a fair point, but not trivial to support unfortunately: it would mean checking if applying `nbstripout` would have created a diff, which...

It will tell you which files are in scope / would be touched. I agree that your definition is more useful.

@joaonc only tangentially. This request is about turning `--dry-run` into an "actual" dry run and only report if any changes would have been made.

@alonme Would you be interested in implementing this?

@swateek sure! You'd need to change [this line](https://github.com/kynan/nbstripout/blob/master/nbstripout/_nbstripout.py#L474) to not overwrite the notebook and then in the following `if args.dry_run:` block you'd need to check if any changes were applied...

@michaelaye Do you have `core.preloadindex` enabled? That might be it: > Enable parallel index preload for operations like git diff > > This can speed up operations like git diff...

Thanks, @stas00! Feel free to send a PR for the `rapidjson` variant. I'd also be open to add the `nbstripout-jq` as a separate script.

That's a tricky one: the path to the Python interpreter and nbstripout are indeed hard coded - deliberately. The point is to make the filter work independently of the environment...