Kuba Werłos

Results 57 comments of Kuba Werłos

https://github.com/kriswallsmith/assetic/pull/803 is fixing the issue.

I wonder what about these cases: ```php function a(): void { } function b( int $x ) { } ``` not mentioning other cases. Maybe it is worth raising a...

> What am I missing? @mmenozzi the idea of this tool ;) -> https://github.com/maglnet/ComposerRequireChecker#whats-it-about

No, not only, in general test "if" condition. Maybe better example would be with with `return false`. The real life scenario would be some validator like this: ```php function isValid($a,...

The CLI `fix` command is using a runner: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.0.0/src/Console/Command/FixCommand.php#L318 - you can simply use it as well. Or with Symfony Process component you can run command from code: https://github.com/kubawerlos/php-cs-fixer-config/blob/v2.0.0/src/Builder/build.php#L19

Wouldn't [extending](https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4908) `PhpUnitExpectationFixer` be better (less code and no introducing new fixer) approach?

Can `multiline_whitespace_before_semicolons` be a proxy to `whitespace_before_statement_end`?

What about this https://github.com/KorvinSzanto/PHP-CS-Fixer/blob/feature/psr12/src/RuleSet.php#L60 ? Is this finished, abandoned or what?

Very good idea, if one has non-monolithic files the priority should not be coding standards, but getting rid of them, it's not 1995 anymore. I wonder it the change would...

Is this because of promoted properties? If so take a look at [`MultilinePromotedPropertiesFixer`](https://github.com/kubawerlos/php-cs-fixer-custom-fixers#MultilinePromotedPropertiesFixer). Then you have to update [`TrailingCommaInMultilineFixer`](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.6.0/doc/rules/control_structure/trailing_comma_in_multiline.rst) configuration by adding `parameters`.