Kuba Werłos
Kuba Werłos
> ohh my.. getting a green build for a README.rst change is a real pain in the ass. @staabm what is the problem? It is very easy.
@keradus WDYT about adding this: https://github.com/kubawerlos/PHP-CS-Fixer/blob/add_ExcludedPhrasesTest/tests/AutoReview/ExcludedPhrasesTest.php#L33 test for all the deprecated constants?
@aidantwoods what is the problem? If only `README.rst` then remove it and run `php dev-tools/doc.php` to generate fresh docs.
This fixer brings third place for header comment - which makes tests much more complicated. Lets consider having following template: ```php
What if they are the same? Then remove it? What I meant is having 2 locations we have issues like https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/2590 and https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/3467, so adding third location without properly handling...
In `Tokenizer/Analyzer` we have `ArgumentsAnalyzer`, `CommentsAnalyzer` and so on - I mean have plural names - therefore can we rename this analyzer to `ClassesAnalyzer`?
Another case (obfuscated from an existing project, I wouldn't came with such case by myself, I'm not that creative) that will crash the fixer: ```php
What about adding the fixer to our `.php_cs.dist`? I think we should do that. But not yet, @grubersjoe, when you give it a go and you will find - among...
Can you do `rebase`? Right now diff shows adding redundant docs in `tests/Tokenizer/Analyzer/CommentsAnalyzerTest.php`
@mvorisek https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6619