Yoshiya Hinosawa

icon indicating a website link https://kt3k.org

icon company @denoland icon location Tokyo, Japan icon location A web dev in 🇯🇵. Work on @denoland. Current hobby: VSCode Custom Editor

Results 643 comments of Yoshiya Hinosawa

Bug: `vitest run --coverage` crashes with panic

#25198 might solve this issue

suggestion: have `deno coverage --html` generate coverage badge

I think this can be done with simple string operations. `shields` crate seems overkill for us which tries to solve more general problem

`.bashrc` lines should be added by default in the install one-liner

Historically we keep rejecting this suggestion. ref #52 #157 #177 #178 #231 #268 One reason is that proper shell detection is more difficult in *nix system (there are many shells...

`.bashrc` lines should be added by default in the install one-liner

Bun, for example, does the detection of bash, zsh, fish, and it takes ~116 lines for it https://github.com/oven-sh/bun/blob/ba5dd63eb6d2855fd814fbc92589f796b5b8adf5/src/cli/install.sh#L179-L295, which is almost double of our current install.sh (60 lines). I'm not...

Question: value type check functions

I'm not in favor of having `isBoolean` or `isString` (even as internal utils). Inline expressions `typeof val === "string"` and `typeof val === "boolean"` should be better than having utils.

to-do: make `@std/http/file-server` compatible with `deno serve --parallel`

Is there a way to detect if the script is executed with `deno serve`?

BREAKING(log): change `setup` and `destroy`

I'm not in favor of this change. This doesn't solve anything, but changes things in breaking way, based on aesthetic reason/naming preference.

BREAKING(log): change `setup` and `destroy`

I'm not in favor of either. > it removes the necessity of having the setup and destroy functions at all and thus simplifies the api. I don't understand this. It...

feat(http/unstable): `parallel-file-server` module

Should we add some warning about that the script is still unstable?

path: make some `@std/path` functions work with file URL object

I think this also makes sense for other functions such as `basename`, `extname`, ~~`common`~~, `join`, `relative`, and `resolve`