Yoshiya Hinosawa

icon indicating a website link https://kt3k.org

icon company @denoland icon location Tokyo, Japan icon location A web dev in 🇯🇵. Work on @denoland. Current hobby: VSCode Custom Editor

Results 643 comments of Yoshiya Hinosawa

refactor(assert): align additional error messages

#5797 makes sense to me. Closing this one for now

Different behavior for fetch call between Node.js & Deno

@MiguelRipoll23 What was the 'urn' value in the first example in Deno?

[RFE] @std/http/file_server - Allow to modify file contents on-the-fly

Doesn't sounds like a common needs to a static file server. I'd recommend you should read the file on your own handler, modify it, and respond: ```ts Deno.serve(async (req) =>...

[RFE] @std/http/file_server - Allow to modify file contents on-the-fly

`Deno.serve` and `@std/http` covers common needs around HTTP protocol, but they don't try to be a _ready-to-use_ web framework. I guess what you are looking for is web frameworks (such...

Normalize error message grammar

For the further work, I don't think we need to align the error messages only used in test cases. Let's only work on user-facing errors

Normalize error message grammar

The style guide has been landed in #5671

Normalize error message grammar

@irbull Sounds good enough for now. Thank you for your contributions!

fix(ext/http): do not set localhost to hostname unnecessarily

@bartlomieju Does this change look reasonable?

Deno namespace inconsistency

FYI `denoland/std` replaced all these patterns of names a while ago. https://github.com/denoland/std/pull/2582

Bug: `vitest run --coverage` crashes with panic

The error now looks like the below (Updated the title): ``` Error: Not implemented: inspector.Session.prototype.connect ❯ notImplemented ext:deno_node/_utils.ts:9:9 ❯ Session.connect node:inspector:12:5 ❯ startCoverage node_modules/.deno/@[email protected]/node_modules/@vitest/coverage-v8/dist/index.js:6:11 ❯ Object.startCoverage node_modules/.deno/@[email protected]/node_modules/@vitest/coverage-v8/dist/index.js:44:12 ❯ startCoverageInsideWorker node_modules/.deno/[email protected]/node_modules/vitest/dist/chunks/coverage.CqfT4xaf.js:47:42...