Yoshiya Hinosawa

Results 643 comments of Yoshiya Hinosawa

The suggestion sounds reasonable to me. One thing to note here is that CLI currently replace "0.0.0.0" with "localhost" to workaround some issue in windows (So the check of `localhost`...

> When you said "We might also need to address that issue", did you have something in mind — like an alternate method for determining the original hostname value? I...

Ok. I'll work on `denoland/deno` part. (I'll first try to land https://github.com/denoland/deno/pull/24698 to avoid the conflicting work)

How about making the output destination optional (like, `output: "stderr"`) instead of changing the default behavior?

We can do that for Spinner. But we'd like to avoid changing it for `promptSecret` as it's already stabilized. > will corrupt any expected structured output from a process (e.g....

I'm not sure this is a bug or not. It looks like the current `isGlob` seems assuming windows path separator is given as four backslashes: ``` \\\\ ``` (I guess...

We used to have JS implementation of uuid v4, but switched to crypto.randomUUID() in #971. Maybe we can restore that logic as fallback path.

@lucacasonato Do you have opinions to the idea of adding back `v4.generate()` function with fallback to js implementation like `npm:uuid` does? (https://github.com/uuidjs/uuid/blob/main/src/v4.js)

I think the tricky part of this is how to maintain the list of irregular words. Is there a good reference we can rely on?

@Liam-Tait Thank you for your contributions! Closing as completed