deno_std icon indicating copy to clipboard operation
deno_std copied to clipboard

feat(http/unstable): `parallel-file-server` module

Open iuioiua opened this issue 1 year ago • 2 comments

Closes #5681

iuioiua avatar Aug 23 '24 01:08 iuioiua

Codecov Report

Attention: Patch coverage is 9.37500% with 29 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (a81742a) to head (c56fa0b). Report is 23 commits behind head on main.

Files Patch % Lines
http/_get_server_args.ts 6.66% 28 Missing :warning:
http/file_server.ts 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5786      +/-   ##
==========================================
- Coverage   96.26%   96.24%   -0.02%     
==========================================
  Files         481      482       +1     
  Lines       38738    38743       +5     
  Branches     5615     5615              
==========================================
- Hits        37291    37290       -1     
- Misses       1406     1412       +6     
  Partials       41       41              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '24 01:08 codecov[bot]

Should we add some warning about that the script is still unstable?

kt3k avatar Aug 23 '24 03:08 kt3k

There are multiple ways we can go about having a HTTP file server work in parallel. I'm not sure this approach is best as I'm not sure having a whole new endpoint is the best way to go. Alternatively, we could have --parallel just work with Deno.serve(), which would make this work a lot simpler.

iuioiua avatar Aug 26 '24 02:08 iuioiua