Yoshiya Hinosawa
Yoshiya Hinosawa
@bartlomieju Oh, it was 1630. The tool [nps](https://www.npmjs.com/package/nps) stops on the error about `process.binding('wrap_tty').TTY` ``` $ deno run --compat --unstable -A node_modules/.bin/nps error: Uncaught (in promise) TypeError: process.binding is not...
#13553 resolved many issues in mocha compatibility!
Here https://github.com/mochajs/mocha/blob/d7f6ea5f5d8406204053618c708634dbf5aa9670/lib/nodejs/parallel-buffered-runner.js#L14, mocha shadows `setInterval` in wrapper function scope with global one. It disables our providing-timers-in-wrapper-function hack 😬
Maybe we can fake `global` object using `Proxy` 🤔
The first one comes from here https://github.com/denoland/deno/blob/81d73f2/cli/module_graph.rs#L1821, and the second one from here https://github.com/denoland/deno/blob/1a9209d/cli/tsc/99_main_compiler.js#L268 ~~The first case looks just ok to throw JS error. Probably we shouldn't throw for the...
@kitsonk Sorry for changing the opinion again about this, but after checking the [URL spec](https://url.spec.whatwg.org/#path-or-authority-state) and the behaviors of whatwg-url (npm module) and rust-url (our depencency), I think the parsed...
@kitsonk > Why wouldn't the logic of "if the pathname is empty, attempt to look at the hostname" be inappropriate? I'm now working towards this direction. I was able to...
Memo: I found that typescript normalizes the path during handling op_load call, ref: https://github.com/microsoft/TypeScript/blob/0383b5cb4c96083c12ea1453bf129fe675abaac9/src/compiler/program.ts#L2230-L2232 which replaces, for example, '//' to '/' in the middle of path: ```ts const id =...
@caspervonb I agree that could be another solution. @kitsonk What do you think?
I recently found many unhandled `assertRejects()` calls, even in deno_std itself. People very often forget to put `await` before them.