Yoshiya Hinosawa

`node-gyp` internally uses `npm:make-fetch-happen` for making http request, and that package doesn't seem working with this branch. The below script works with Node and stable Deno, but doesn't with this...

`make-fetch-happen` uses `HttpAgent` from `@npmcli/agent`, and this branch seems incompatible with that http agent. ```ts import npmAgent from "@npmcli/agent"; import { request } from "node:http"; const agent = new npmAgent.HttpAgent();...

~~I guess this workaround (stopping startTls in `afterConnect` in tls.connect) is still necessary. ref: https://github.com/denoland/deno/pull/25470/commits/8e55dab349588b3d4706c8c84e2878dcfe2e156a~~ ~~I'll trying restore that workaround and see if it fixes `node-gyp` issue.~~ nevermind

This should be ready for review again now. PTAL @bartlomieju

@mariusheil Thanks for your report! Could you share some minimal script to reproduce the issue? I'd also appreciate if you would open a new issue about that

Let's add the deprecation notice when it's shipped to Deno (and maybe Chrome). Note: According to MDN, Safari and Firefox already implement it. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/escape

@lionel-rowe Can you move `shuffle` and this version of `sample` to `std/random` (leaving the existing `collections/sample` untouched)? Also I'd prefer to see `SeededPrng` exported from `@std/random/seeded-prng`, `randomBetween` from `@std/random/between`, `randomIntegerBetween`...

> @kt3k Wouldn't that be confusing to have two sample() functions? Or do you mean to deprecate collections/sample in another PR? I think we can deprecate `collections/sample` when we stabilize...

> One possible idea: accept both Uint8Array and standard arrays of Bytes as inputs (maximum ergonomics for both hard-coded and non-hard-coded use), while emitting arrays of Bytes in the output...

Thanks for the feedback. Yes, Astro 5 should be supported now (thanks to #37). The note above looks outdated. We'll try remove that note soon.