Eric G. Kratz
Eric G. Kratz
@vidipsingh It looks like tests are still failing here
@vidipsingh You still need to find a way to fix the tests if you want to continue on this PR
@vidipsingh Are you still working on this?
@BradyPlanden Can you take a look at this?
@brosaplanella What did you think of my groupings of parameters? Are the close enough or do they still need work?
> To be totally honest I don't like this change. I like the split to different components, but by making it a class it feels like it moves us further...
This is badly outdated, so I am going to close it
A process like this should work: ``` # Setup environment virtualenv .venv source .venv/bin/activate git clone [email protected]:pybamm-team/pybammsolvers.git git clone [email protected]:pybamm-team/PyBaMM.git # Install PyBaMM cd PyBaMM pip install -e ".[all,dev,jax]" #...
@BradyPlanden I could not reproduce the original issue when testing this, and fork() on MacOS seems to be problematic with numpy 2.0.0 and the ScipySolver If you can find a...
@RuiheLi, @DrSOKane Can you help with this?