Eric G. Kratz
Eric G. Kratz
Since the original notebook works, and the messages in the last update are just informative (as opposed to errors), I am going to assume this can be closed. I ran...
@BradyPlanden Could you take a look at this?
Related to #3909
@mohammedasher Are you still working on this?
> I will work on fixing the failing tests. Should I also start working on adding new tests for this method? @medha-14 Coverage reports will only start appearing for this...
@medha-14 Sorry for the delay on this one, I will start reviewing this again
Please also add a change log entry. Note that we are doing a release, so once #4598 is merged, there will likely be a merge conflict in the changelog
@allcontributors add @medha-14 for code
I will merge once I see the windows 3.9 check pass. I do not expect a problem, so this should be merged in a couple minutes
Looks like the examples are failing here: ``` for phase in self.options.phases[domain]: if particle == "Fickian diffusion": submod = pybamm.particle.FickianDiffusion( self.param, domain, self.options, phase=phase, x_average=True ) elif particle in [...