Eric G. Kratz
Eric G. Kratz
@prady0t Looks like a good improvement to me. It caught asserts in main code as well. We probably want to raise exceptions or log warnings instead.
I think from here we could try suppressing the asserts in codacy (if that does not cause issues in ruff's analysis) then just rely on ruff for most of it....
I suspect codacy is "happy" because it only flags new findings. No new asserts were added in the tests here. I think Codacy is still going to have findings when...
In my local tests the bandit.yml file does not seem to stop ruff from finding asserts in the main code, so we should add that back
@agriyakhetarpal, @prady0t That is what I am pointing out. The bandit.yml file was remove from this PR. It should be put back otherwise codacy will continue to flag pytest updates
@prady0t Thanks, should be good now
@prady0t While you are at it, can you add the type hints to the function call?
Tests were passing before along with coverage, so I will merge this shortly
@sanjayh-2022 Are you still working on this?
There has been no activity since the end of October, closing this for now