Eric G. Kratz

Results 201 comments of Eric G. Kratz

I will try work on that windows failure this weekend. It could be that we just need to update numpy before that works

I tried this out locally on a windows machine with python 3.13, and it looked like it was trying to build some libraries from source for numpy. This was a...

I have my own branch for this now since there were a lot of changes since this was opened. I am going to close this for now

@Rishab87 From my side we mostly just need traceability on the open items

> @kratman I've already addressed open items here: > > * used `t_eval` & `t_interp` as told there in all the unit tests. > * used reasonable tolerances in unit...

> @kratman yeah sure I'll keep jax seperate this PR does not have any jax related code, by ticket you mean should I create a seperate issue for jax? Yes

@parkec3 Do you want to continue looking into this since you worked on the other PR?

> @parkec3 Do you want to continue looking into this since you worked on the other PR? Never mind, @valentinsulzer already made a branch for a fix

I am looking into the docs failure now, probably something pretty minor

> I am looking into the docs failure now, probably something pretty minor I pushed a temporary fix for the failing citation so that review could continue, I will push...