Eric G. Kratz

Results 201 comments of Eric G. Kratz

@leigedove Can you post a minimum working example and the error? I would also recommend upgrading to pybamm 25.4.2

The `strict=False` was added automatically by ruff and there is no guarantee that the tests will catch all errors from the automatic changes. In the same PR it did not...

@chuckliu1979 We are working on linux arm64 support at the moment. This will be fixed in the near future, we have two different work packages trying to resolve this issue

This will be covered by this ticket: https://github.com/pybamm-team/pybammsolvers/issues/19 I am working on the issues now

I will squash this after tests pass. @all-contributors please add @kawaMANMI for code

@santacodes Are you still working on this?

Not really a bug, so changed the title

@prady0t Is your branch still having problems? Do you need help fixing the branch?

Is codacy even doing anything for us? Can we just make ruff stricter?

I do think it is good to check for complexity (which codacy does), and asserts should be avoided in the main codebase. I think there is a lot we could...