PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Add base parameter class

Open kratman opened this issue 5 months ago • 6 comments

Description

Adds a base class for parameters and groups them into other groups aligned with BPX

Related: #3909

Type of change

  • [x] New feature (non-breaking change which adds functionality)

Key checklist:

  • [x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • [x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • [ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • [x] Code is commented, particularly in hard-to-understand areas
  • [x] Tests added that prove fix is effective or that feature works

kratman avatar Aug 26 '24 16:08 kratman