PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Added an option for multiple initial conditions in IDAKLU solver

Open Rishab87 opened this issue 8 months ago • 4 comments

Description

Added an option for multiple initial conditions in IDAKLU solver

Fixes #3713

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • [x] No style issues: nox -s pre-commit
  • [x] All tests pass: nox -s tests
  • [x] The documentation builds: nox -s doctests
  • [x] Code is commented for hard-to-understand areas
  • [x] Tests added that prove fix is effective or that feature works

Rishab87 avatar Apr 17 '25 17:04 Rishab87

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 98.88%. Comparing base (43f8f43) to head (5ccacf2). :warning: Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4981   +/-   ##
========================================
  Coverage    98.88%   98.88%           
========================================
  Files          320      320           
  Lines        26949    26981   +32     
========================================
+ Hits         26648    26680   +32     
  Misses         301      301           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 17 '25 22:04 codecov[bot]

@martinjrobins Thanks for the review, I've made few changes accordingly and replied to all the comments

Rishab87 avatar Apr 27 '25 11:04 Rishab87

@martinjrobins thanks for the review again, I've made few changes in the tests and replied to the comments

Rishab87 avatar May 01 '25 09:05 Rishab87

@martinjrobins thanks for the review

Rishab87 avatar Jun 17 '25 12:06 Rishab87

@kratman any updates on this?

Rishab87 avatar Jul 22 '25 14:07 Rishab87

@Rishab87 From my side we mostly just need traceability on the open items

kratman avatar Jul 22 '25 14:07 kratman

@kratman I've already addressed open items here:

  • used t_eval & t_interp as told there in all the unit tests.
  • used reasonable tolerances in unit tests rtol=1e-3 & atol=1e-5.
  • Added integration tests for PDE models (SPM & DFN).

Anything else you would like to know?

Rishab87 avatar Jul 22 '25 15:07 Rishab87

@kratman I've already addressed open items here:

  • used t_eval & t_interp as told there in all the unit tests.
  • used reasonable tolerances in unit tests rtol=1e-3 & atol=1e-5.
  • Added integration tests for PDE models (SPM & DFN).

Anything else you would like to know?

I think a ticket for the Jax solver portion would be good

kratman avatar Jul 22 '25 17:07 kratman

@kratman yeah sure I'll keep jax seperate this PR does not have any jax related code, by ticket you mean should I create a seperate issue for jax?

Rishab87 avatar Jul 22 '25 17:07 Rishab87

@kratman yeah sure I'll keep jax seperate this PR does not have any jax related code, by ticket you mean should I create a seperate issue for jax?

Yes

kratman avatar Jul 25 '25 17:07 kratman

Created the issue.

Rishab87 avatar Jul 25 '25 17:07 Rishab87

@kratman @martinjrobins any updates on this one?

Rishab87 avatar Sep 07 '25 11:09 Rishab87