Added an option for multiple initial conditions in IDAKLU solver
Description
Added an option for multiple initial conditions in IDAKLU solver
Fixes #3713
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
- [x] No style issues:
nox -s pre-commit - [x] All tests pass:
nox -s tests - [x] The documentation builds:
nox -s doctests - [x] Code is commented for hard-to-understand areas
- [x] Tests added that prove fix is effective or that feature works
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 98.88%. Comparing base (43f8f43) to head (5ccacf2).
:warning: Report is 1 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #4981 +/- ##
========================================
Coverage 98.88% 98.88%
========================================
Files 320 320
Lines 26949 26981 +32
========================================
+ Hits 26648 26680 +32
Misses 301 301
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@martinjrobins Thanks for the review, I've made few changes accordingly and replied to all the comments
@martinjrobins thanks for the review again, I've made few changes in the tests and replied to the comments
@martinjrobins thanks for the review
@kratman any updates on this?
@Rishab87 From my side we mostly just need traceability on the open items
@kratman I've already addressed open items here:
- used
t_eval&t_interpas told there in all the unit tests. - used reasonable tolerances in unit tests
rtol=1e-3&atol=1e-5. - Added integration tests for PDE models (SPM & DFN).
Anything else you would like to know?
@kratman I've already addressed open items here:
- used
t_eval&t_interpas told there in all the unit tests.- used reasonable tolerances in unit tests
rtol=1e-3&atol=1e-5.- Added integration tests for PDE models (SPM & DFN).
Anything else you would like to know?
I think a ticket for the Jax solver portion would be good
@kratman yeah sure I'll keep jax seperate this PR does not have any jax related code, by ticket you mean should I create a seperate issue for jax?
@kratman yeah sure I'll keep jax seperate this PR does not have any jax related code, by ticket you mean should I create a seperate issue for jax?
Yes
Created the issue.
@kratman @martinjrobins any updates on this one?