pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters

Open gabo1208 opened this issue 4 years ago • 3 comments

Problem As stated on the Cloud Events Spec the attribute naming convention suggest (SHOULD, not MUST) that the names are no longer than 20 characters. We should add at maybe a warning for that cases, even when this does not imply an error. Also, when there are keys with upper case letters there could be a collision (cause the keys get converted to lower-case), in that keys the value corresponds with the last defined key (generally)

Persona: Producers, consumers and integrators

Exit Criteria When you set an extension name longer than 20 characters on any source.spec.ceOverride.extensions extension, the logs show a warning about that extension name

Additional context (optional) Here should be any warning or validation related to sources 😉

gabo1208 avatar Sep 02 '21 16:09 gabo1208

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Dec 03 '21 01:12 github-actions[bot]

/remove-lifecycle stale /triage accepted /reopen

pierDipi avatar Jan 03 '22 07:01 pierDipi

@pierDipi: Reopened this issue.

In response to this:

/remove-lifecycle stale /triage accepted /reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot avatar Jan 03 '22 07:01 knative-prow-robot