pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Remove KProbe logic from Drainer

Open nader-ziada opened this issue 4 years ago • 5 comments

/area networking

Follow up from Serving PR: https://github.com/knative/serving/pull/12033

  • comment about KProbe logic in drainer being a duplicate functionality https://github.com/knative/serving/pull/12033#pullrequestreview-779938231
A related concern (but I don't think it should block this PR) is why the drainer has KProbe logic in it
https://github.com/knative/pkg/blob/main/network/handlers/drain.go#L157

I think that makes the network.NewProbeHandler a noop in this instance
https://github.com/knative/networking/blob/main/pkg/probe_handler.go#L37
  • Other comment about same https://github.com/knative/serving/pull/12033#discussion_r735640426

nader-ziada avatar Oct 25 '21 15:10 nader-ziada

cc @runzexia who included the KProbe logic in the drainer - is there a reason you couldn't consume the handler from knative.dev/networking ?

dprotaso avatar Oct 26 '21 20:10 dprotaso

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jan 25 '22 01:01 github-actions[bot]

/remove-lifecycle stale

pierDipi avatar Jan 25 '22 09:01 pierDipi

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Apr 26 '22 01:04 github-actions[bot]

/lifecycle frozen

dprotaso avatar Apr 26 '22 21:04 dprotaso