Remove KProbe logic from Drainer
/area networking
Follow up from Serving PR: https://github.com/knative/serving/pull/12033
- comment about KProbe logic in drainer being a duplicate functionality https://github.com/knative/serving/pull/12033#pullrequestreview-779938231
A related concern (but I don't think it should block this PR) is why the drainer has KProbe logic in it
https://github.com/knative/pkg/blob/main/network/handlers/drain.go#L157
I think that makes the network.NewProbeHandler a noop in this instance
https://github.com/knative/networking/blob/main/pkg/probe_handler.go#L37
- Other comment about same https://github.com/knative/serving/pull/12033#discussion_r735640426
cc @runzexia who included the KProbe logic in the drainer - is there a reason you couldn't consume the handler from knative.dev/networking ?
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
/remove-lifecycle stale
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
/lifecycle frozen