pkg
pkg copied to clipboard
Knative common packages
/area API /kind bug _This is a largely superficial issue, which I only noticed because of some unit testing I was writing and trying to explain this odd behavior._ ##...
# Changes The Knative controller infrastructure uses by default two threads per controller. This setting is not configurable in Knative itself while [Tekton allows to configure it](https://github.com/tektoncd/pipeline/blob/v0.38.2/cmd/controller/main.go#L46). [I was playing...
``` === RUN TestDialTLSWithBackoffSuccess [247](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2362/unit-tests_pkg_main/1552288716540612608#1:build-log.txt%3A247) 2022/07/27 13:44:46 http: TLS handshake error from 127.0.0.1:38562: EOF [248](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2362/unit-tests_pkg_main/1552288716540612608#1:build-log.txt%3A248) 2022/07/27 13:44:46 http: TLS handshake error from 127.0.0.1:38564: EOF [249](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2362/unit-tests_pkg_main/1552288716540612608#1:build-log.txt%3A249) 2022/07/27 13:44:47 http: TLS handshake...
## Actual Behavior Creating 2 defaulting webhooks `w1` and `w2` inside the same pod for 2 different mutating webhook configuration manifests doesn't work since the lease name is based on...
/area API /kind bug ## Steps to Reproduce the Problem Using "warning" level error introduced in #2498: ``` func TestFoo(t *testing.T) { var errs *apis.FieldError errs = errs.Also(apis.FieldError("foo").At(apis.WarningLevel)) if errs.Level...
/area test-and-release /kind bug ## Expected Behavior `wait.PollImmediate` should keep on polling if I pass response checkers through `WaitForEndpointState` https://github.com/knative/pkg/blob/main/test/request.go#L78 until the state is reached or timeout happens. ## Actual...
This isn't always the case - https://github.com/knative/pkg/pull/2291
# Changes - Exposes the reporting period used by Prometheus and Opencensus backend destinations. - Required for fixing https://github.com/knative/serving/issues/12069 /kind api-change
metrics/resource_view_test.go - TestMetricsExport flakes most of the time. /assign @jjzeng-seattle @evankanderson here's a good example: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/1666/pull-knative-pkg-unit-tests/1300475037081407489
Creating 2 defaulting webhooks w1 and w2 inside the same pod for 2 different mutating webhook configuration manifests doesn't work since the lease name is based on the hardcoded queue...