pkg Multiple defaulting webhooks don't work

trafficstars

Actual Behavior

Creating 2 defaulting webhooks w1 and w2 inside the same pod for 2 different mutating webhook configuration manifests doesn't work since the lease name is based on the hardcoded queue name DefaultingWebhook.

	const queueName = "DefaultingWebhook"
	c := controller.NewContext(ctx, wh, controller.ControllerOptions{WorkQueueName: queueName, Logger: logger.Named(queueName)})

so, we get a pod competing for the same lease in 2 separate reconcilers for 2 separate webhooks.

Expected Behavior

Allow having multiple defaulting webhooks served by the same pod.

Steps to Reproduce the Problem

Create defaulting webhook w1
Create an Admission controller for w1 in the main
Create defaulting webhook w2
Create an Admission controller for w2 in the main
Observer that rules are applied for on only 1 of them

Additional Info

/area API /kind bug

Feb 02 '22 17:02 pierDipi

What's the use case here? Since you effectively control the component why not create a single admission controller with all the relevant types?

Feb 03 '22 15:02 dprotaso

that doesn't work because I need to define my own object selectors for only a subset of types.

Feb 03 '22 18:02 pierDipi

The use case is to have a webhook that responds on some types within a namespace with a specific label and another one that responds on some types in any namespace.

Feb 03 '22 18:02 pierDipi

@dprotaso the only problem is the hardcoded const queueName = "...", I can go with overriding only the queue name without overriding the whole ControllerOptions as in https://github.com/knative/pkg/pull/2420

Feb 04 '22 09:02 pierDipi