kennytm
kennytm
Contributions are welcome! 😄
The issue is not whether it's rare, but that for these `ioctl`s passing values directly are the only way to communicate with the kernel. If you want to use `TUNSETOFFLOAD`...
this is a duplicate of #361.
``` pkg/cmd/redo/apply.go:18:2: G108: Profiling endpoint is automatically exposed on /debug/pprof (gosec) _ "net/http/pprof" // init pprof ^ ``` 😒
/retest ``` === FAIL: engine/servermaster TestExecutorManagerWatch (2.00s) executor_manager_test.go:184: Error Trace: /home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:184 /usr/local/go/src/runtime/asm_amd64.s:1598 Error: Received unexpected error: [DFLOW:ErrUnknownExecutor]unknown executor: -8cad396c github.com/pingcap/errors.AddStack /go/pkg/mod/github.com/pingcap/[email protected]/errors.go:174 github.com/pingcap/errors.(*Error).GenWithStackByArgs /go/pkg/mod/github.com/pingcap/[email protected]/normalize.go:164 github.com/pingcap/tiflow/engine/servermaster.(*ExecutorManagerImpl).HandleHeartbeat /home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager.go:136 github.com/pingcap/tiflow/engine/servermaster.TestExecutorManagerWatch.func4.1 /home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:183 runtime.goexit /usr/local/go/src/runtime/asm_amd64.s:1598 Test:...
> Often folks use the GitHub review thing to say "approved, but here are some minor changes you should make and then self-r+" The r+ command is only interpreted you...
Okay my understanding was that homu should respond to review comments (which are currently ignored). I agree that pressing "Approve" should *not* be equivalent to r+, without mentioning `@bors` the...
@alexrs It is a bit messy but you could check https://github.com/kennytm/test-term-coloring/pull/7#issuecomment-376501042 and https://github.com/kennytm/test-term-coloring/pull/8#issuecomment-376501042. * 2018-03-27T12:08:03Z: r+ on PR 7 issued * 2018-03-27T12:08:05Z: r+ on PR 7 acknowledged * 2018-03-27T12:08:09Z: r+...
PTAL @zimulala