kennytm
kennytm
Yeah as I've mentioned in #2795 perhaps it's better to go all-in supporting `{(expr)}`. You'll need to deal with side-effect due to custom Deref anyway. ---- BTW #2795's Future possibilities...
> The benefit of the `else as` approach is that code can be shared between branches, notably the terminating statement: you could still do so with a catch-all `match`. for...
> I guess my main clarification here was that due to the polar-orthogonal discrepancy > > [...] > > My point here isn't that we need to decide; the issue...
Currently when you `#[derive(PartialEq)]` the compiler will automatically implement [`StructuralPartialEq`](https://doc.rust-lang.org/std/marker/trait.StructuralPartialEq.html) too (#3535). If any field is `#[ignore(PartialEq)]`'ed should we still consider the type having structural equality?
@rcvalle do you mean [`@rfcbot fcp merge compiler`](https://github.com/rust-lang/rfcbot-rs/blob/master/README.md#proposing-fcp)
For the `Matrix` case IMO the more proper solution is to support "custom dynamic-sized-type" like `type Mat = [[T]];`[^1], so that instead of `Matrix`, `MatrixRef` you use `Box`, `&'a Mat`,...
> Is saving two characters (`from..to.0` vs. `from..to`) worth the API churn? I'd probably write it `from..to.into()` anyway. Right I think OP's motivation is not good enough since LineIndex →...
* We already have an ongoing PR to upgrade the gRPC dependency in #1779. * Also, we normally don't expect contribution directly to the `tidb-8.5` branch. New changes should be...
~~The solution sketch panics on div-by-zero (via calling `self % rhs`).~~ With the name `exact_div_or_rem` it is more clear that it should panic, and the non-panicking variant could be named...
this sounds more like a *funnel* shift operation (i.e. #642) than just a "shift" which I though it would be filled with a constant like `T::default()`. there is a similar...