tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

redo(ticdc): enable pprof and set memory limit for redo applier (#10904)

Open ti-chi-bot opened this issue 1 year ago • 5 comments

This is an automated cherry-pick of #10904

What problem does this PR solve?

Issue Number: close #10900

What is changed and how it works?

  1. Set memory limit for redo applier.
  2. Enable pprof for redo applier to simplify troubleshooting.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

ti-chi-bot avatar Apr 27 '24 14:04 ti-chi-bot

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 27 '24 14:04 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign charlescheung96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 27 '24 14:04 ti-chi-bot[bot]

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 1e9ad2de6e99fdc59c568528dabd456206a704db link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Apr 27 '24 15:04 ti-chi-bot[bot]

/test verify

kennytm avatar Aug 30 '24 02:08 kennytm

pkg/cmd/redo/apply.go:18:2: G108: Profiling endpoint is automatically exposed on /debug/pprof (gosec)
	_ "net/http/pprof" // init pprof
	^

😒

kennytm avatar Aug 30 '24 03:08 kennytm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from charlescheung96, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Aug 30 '24 03:08 ti-chi-bot[bot]

/retest

=== FAIL: engine/servermaster TestExecutorManagerWatch (2.00s)
    executor_manager_test.go:184: 
        	Error Trace:	/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:184
        	            				/usr/local/go/src/runtime/asm_amd64.s:1598
        	Error:      	Received unexpected error:
        	            	[DFLOW:ErrUnknownExecutor]unknown executor: -8cad396c
        	            	github.com/pingcap/errors.AddStack
        	            		/go/pkg/mod/github.com/pingcap/[email protected]/errors.go:174
        	            	github.com/pingcap/errors.(*Error).GenWithStackByArgs
        	            		/go/pkg/mod/github.com/pingcap/[email protected]/normalize.go:164
        	            	github.com/pingcap/tiflow/engine/servermaster.(*ExecutorManagerImpl).HandleHeartbeat
        	            		/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager.go:136
        	            	github.com/pingcap/tiflow/engine/servermaster.TestExecutorManagerWatch.func4.1
        	            		/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:183
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1598
        	Test:       	TestExecutorManagerWatch
    executor_manager_test.go:228: 
        	Error Trace:	/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:228
        	Error:      	Condition never satisfied
        	Test:       	TestExecutorManagerWatch

kennytm avatar Aug 30 '24 04:08 kennytm

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify e6c0d6e41c0a96cdcd00ec12360620af6ae444b9 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Aug 30 '24 04:08 ti-chi-bot[bot]