kennytm
kennytm
@traviscross I think we have concluded from https://github.com/rust-lang/rfcs/pull/3607#discussion_r1561335884 that this RFC is producing the *discriminant*, not the *tag*. #2195 is irrelevant here, it controls the maximum size of the tag...
#3634 is probably the same as this with a different syntax. ```rust mod a { pub use impl Index for [T] { ... } } mod b { fn foo2()...
As of today this repository has 95 open ACPs. Resolving all of them in two-months time (i.e. 8–9 weeks) would mean processing 10–12 proposals per weekly meeting on average. This...
Source of that code snippet: https://github.com/rust-lang/rust/blob/66b4f0021bfb11a8c20d084c99a40f4a78ce1d38/src/tools/compiletest/src/util.rs#L36-L54 A name chosen by the internal "compiletest" tool should not be used as justification to "keep the name `with_extra_extension`".
`#[skip]` is very different from `#[default]` though. `#[skip]` is basically agnostic from the trait being derived (you write `#[skip(Debug)]` not `#[debug(skip)]`), while `#[default]` can only make sense in the Default...
I think the field that is `#[skip]`'ed should be entirely deleted from the TokenStream sent to the proc macro. However currently no similar treatment applied to proc macro: all attributes,...
sorry gotta -1 this one if this is the only motivation: > The rand crate has a [SampleRange](https://docs.rs/rand/latest/rand/distributions/uniform/trait.SampleRange.html) trait implemented only for `Range` and `RangeInclusive`. I don't find this motivating...
The new sample code doesn't work because if `start_inclusive()` returned by value it would need to consume `self`, making `self.end_inclusive()` failing to compile. For a return-by-value method you'll need to...
The original implementation of `sample_single` does not require a clone, only moving. Consider that `T` can be a BigInt. This is an unnecessary performance degradation only because of limitation of...
@Voultapher > For completeness sake, I'm posting the original situation I found RangeBounds lacking for: > > ```rust > /// Returns a new `Vec` with `len` elements, where the elements...