kennytm

A `const fn` is *not* going to support the "register" part of `register_histogram_vec` even after the entire of rust-lang/rust#57563 is implemented, since a `const fn` cannot mutate something the function...

Code coverage via `cargo tarpaulin` is blocked by tikv/tikv#4491.

Hi. Before we merge or close this can you provide where is that `std::hash::Hasher` used? AFAIK cryptographic hash algorithms don't implement `std::hash::Hasher` but rather [`digest::Digest`](https://docs.rs/digest/latest/digest/trait.Digest.html). The main purpose of choosing...

Note: this optimization cannot be applied to partitioned tables, where the table ID differ for every partition, unless we store each partition into separate engines (but this will blow up...

For normal table we set the prefix to be `t«tableID»_r`, and for partitioned table we set the prefix to be `t` (or just an empty string).

https://github.com/awslabs/aws-sdk-rust/issues/966#issuecomment-2075177698 > this *\*[FIPS support]* is now supported if you use our experimental support for Hyper 1.0: https://github.com/awslabs/aws-sdk-rust/blob/main/sdk/s3/tests/hyper-10.rs See also https://github.com/awslabs/aws-sdk-rust/issues/1050#issuecomment-2130057612 for how to use the hyper 1.0 client. The...

stack trace formatted ``` 0: tikv_util::set_panic_hook::{{closure}} at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tikv_util/src/lib.rs:476:18 1: ::call at rust/toolchains/nightly-2023-12-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2029:9 std::panicking::rust_panic_with_hook at rust/toolchains/nightly-2023-12-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:783:13 2: std::panicking::begin_panic_handler::{{closure}} at rust/toolchains/nightly-2023-12-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:649:13 3: std::sys_common::backtrace::__rust_end_short_backtrace at rust/toolchains/nightly-2023-12-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:171:18 4: rust_begin_unwind at rust/toolchains/nightly-2023-12-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:645:5 5: core::panicking::panic_fmt at...

Better also point to https://github.com/rust-lang/rust/pull/93044#issuecomment-1063283366 showing why just avoiding `Arc` is not enough. I think if we further restrict the condition to `where T: Read, &T: Read` it would be...

@ahicks92 in typical Rust that example will be written not as a for loop but a map+collect: ```rust let guards = structures.iter() .map(|s| s.lock.lock().unwrap()) .collect::(); ``` which currently rustc will...

@ahicks92 I haven't used the word "idiomatic" in my response ("standard solution" is talking about suppressing the `unused_variable` lint), I'm just pointing out if this is written in terms of...