kennytm

Results 393 comments of kennytm

@nikomatsakis my preference, in order 1. if crater accepts `k#something` for 2015 and 2018, and we think that it is a valuable breakage (like that of `$(,)?+`), then make `k#something`...

`..x` already means `RangeTo { end: x }`. Try another symbol :wink:

(This should be moved to ACP, if still valid?) > However, in the case the key slot in the container is already occupied, and we get an OccupiedEntry as a...

> Long-running "real-time" systems must not panic for something like this It won't "panic" if you turn off `-C overflow-checks`. If the "real-time" system accepts `a + b` potentially panicking...

I think `Box::map` is good but I'm not sure about `Arc::map` which requires a Clone bound of the inner type. An alternative is making `Arc::map` take a `FnOnce(&T) -> U`...

This isn't a problem specific to Importer. TiKV has the same problem since `SocketAddr::from_str` won't (and shouldn't) do DNS resolution. https://github.com/tikv/tikv/blob/f5215d631d3145d824c0d0940cd490ff3f8bbf80/src/server/server.rs#L104 The TiDB Operator works fine because the TiKV server...

I don't think fixing INSERT is enough to solve the issue. For instance the following does not involve any INSERT afaict. ```sql select hex(random_bytes(16)) from (select 1 union select 2)...

I suggest that, after a DDL ***retry*** has failed because of timeout, we check whether there is any running DDL jobs in downstream. If true, instead of scheduling the 3rd...

🤔 I just realized when `(x y z)*` rendered the nodes will be traveled in opposite order. ![2-fs8](https://user-images.githubusercontent.com/103023/105017827-36b35180-5a7f-11eb-8f83-a57ce023d214.png) But the old image, which flips the nodes, does not look good...

The example in https://github.com/rust-lang-nursery/lazy-static.rs/issues/214#issuecomment-2269883404 is more like a `LazyCell` though. The problems reducing usability of `LazyCell`-style initialization are 1. You need `#![feature(const_async_blocks)]`[^1]. (This use-side feature can be avoided if the...