zhaokuo comments

Results 35 comments of


                                            zhaokuo

[VL] Result mismatch issues Tracker

https://github.com/apache/incubator-gluten/issues/4891

[VL] Result mismatch issues Tracker

https://github.com/apache/incubator-gluten/issues/4928

[VL] Result mismatch issues Tracker

https://github.com/apache/incubator-gluten/issues/4930

[VL] Result mismatch issues Tracker

https://github.com/apache/incubator-gluten/issues/4947

[VL] Result mismatch issues Tracker

https://github.com/apache/incubator-gluten/issues/5366

[VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore")

The following unit test case can reproduce the issue. I'm sure that got wrong value while parsing double in function `SIMDGetJsonObjectFunction::extractStringResult()`. More info about UT can refer to this commit...

[VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore")

> Hi @kecookier, it looks the below small patch can fix this issue. Please help verify it. Thanks! > > [PHILO-HE/velox@a1e9be0](https://github.com/PHILO-HE/velox/commit/a1e9be059ceb03ca4e1c68145e516a9bb07ed956) @PHILO-HE Thanks for your help, I'll try it out...

[VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore")

Hi @PHILO-HE , I have tested it, and that patch can fix the bug. > > Hi @kecookier, it looks the below small patch can fix this issue. Please help...

[GLUTEN-6736][VL][1.2] Port #6741 #6783 #6658

Could you please let me know if there are any issues with this PR that I should address?

Fix warnings caused by -Wunused-but-set-variable

The CI build failed because the `FOLLY_MAYBE_UNUSED` macro could not be found in the specified version of Folly (https://github.com/facebook/folly/archive/refs/tags/v2024.04.01.00.tar.gz). Let's replace it with the `[[maybe_unused]]` attribute instead. ``` In file...