zhaokuo
zhaokuo
> HI @kecookier Please give me couple more days to land this ; have to fix a few failing builds related to this internally. Thanks!
> @kecookier can you please resolve the CI failures I will work on fixing it as soon as possible. Thank you for your patience.
@majetideepak I have rebased the main branch. Could you please help trigger the CI?
@bikramSingh91 Just a friendly ping, the CI has been fixed. Could you please help merge it?
@rui-mo Can you help review this PR?
@rui-mo I've update the code to resolve all comments. Please review again.
@rui-mo All comments updated.
> @kecookier, does presto also use java.util.regex like Spark? @PHILO-HE Sorry, I have not thoroughly investigated Presto's Java code. It seems that Presto supports both JONI and RE2J, and according...
@rui-mo It seems that `regexp_replace` is in the skip list of either ExpressionFuzzerTest or SparkExpressionFuzzerTest. Do you have any ideas?
> Would you update the documentation for both Presto and Spark? The others look good to me. Thanks. > > https://github.com/facebookincubator/velox/blob/main/velox/docs/functions/presto/regexp.rst https://github.com/facebookincubator/velox/blob/main/velox/docs/functions/spark/regexp.rst @rui-mo The documents have been updated. Please review...