zhaokuo comments

Results 35 comments of


                                            zhaokuo

Add pattern and replacement preprocessing to the Spark regexp_replace function

@kagamiori I've rebased onto the latest main, but one of the CI checks failed. It looks like the error is unrelated to this PR. ``` E20241124 03:25:55.815338 80204 Exceptions.h:66] Line:...

[VL] Results are mismatch with vanilla Spark when use regexp_replace('a{bc', '\\{', '\\[')

> thanks @kecookier do you will help fix the issue ? Yes, I will work on this issue.

[VL] Results are mismatch with vanilla Spark when use regexp_replace('a{bc', '\\{', '\\[')

@wang-zhun Sorry for the late reply, and thank you for the information. I have a work-in-progress PR that will fix this issue.

[VL] Results are mismatch with vanilla Spark when use regexp_replace('a{bc', '\\{', '\\[')

@PHILO-HE Apologies for the delayed response. This PR attempts to fix the mismatch problems in `regexp_replace`: https://github.com/facebookincubator/velox/pull/10981

[VL] Results are mismatch with vanilla Spark when use regexp_replace('a{bc', '\\{', '\\[')

https://github.com/facebookincubator/velox/pull/10981 Already merged