zhaokuo
zhaokuo
### Backend VL (Velox) ### Bug description The following SQL might lead to wrong results, but it's not yet certain if there are other factors involved. I will try to...
## What changes were proposed in this pull request? Now we only validate the regex pattern, but we also need to validate the rewrite string. The `regexp_function` will call `RE2::GlobalReplace()`,...
### Backend VL (Velox) ### Bug description ```sql spark-sql> set spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.ConstantFolding; spark-sql> select regexp_replace('a{bc', '\\{', '\\['); vanilla get a[bc gluten get abc ``` ### Spark version Spark-3.2.x ### Spark configurations...
Variable `values` would not be used if the condition `if constexpr (std::is_same_v)` is true. ``` /__w/incubator-gluten/incubator-gluten/cpp/../ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:1416:3: required from here /__w/incubator-gluten/incubator-gluten/cpp/../ep/build-velox/build/velox_ep/velox/exec/RowContainer.h:962:10: warning: variable 'values' set but not used [-Wunused-but-set-variable] 962 |...
We need to add pattern and replacement preprocessing to the regexp_replace function to ensure compatibility with vanilla Spark's native regular expression handling. For patterns, convert `(?regex)` to `(?Pregex)` as with...