incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-6736][VL][1.2] Port #6741 #6783 #6658

Open wForget opened this issue 1 year ago • 15 comments

What changes were proposed in this pull request?

Port #6741 #6783 #6658

How was this patch tested?

wForget avatar Oct 23 '24 03:10 wForget

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] avatar Oct 23 '24 03:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 03:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 05:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 05:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 06:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 08:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 08:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 12:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 12:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 23 '24 15:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 24 '24 12:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 25 '24 11:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 25 '24 11:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 25 '24 11:10 github-actions[bot]

https://github.com/apache/incubator-gluten/issues/6736

github-actions[bot] avatar Oct 25 '24 13:10 github-actions[bot]

Thank you for this effort. It's critical for the stability of release 1.2.

BTW, do you happen to know why Velox backend Github Runner / run-tpc-test-ubuntu-oom is failing? I will help investigate too asap.

zhztheplayer avatar Oct 29 '24 08:10 zhztheplayer

Thank you for this effort. It's critical for the stability of release 1.2.

BTW, do you happen to know why Velox backend Github Runner / run-tpc-test-ubuntu-oom is failing? I will help investigate too asap.

I haven't determined the cause of failure yet, I will try to verify separately commits to determine which change caused this failure.

wForget avatar Oct 29 '24 09:10 wForget

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 30 '24 05:10 github-actions[bot]

@zhztheplayer GHA checks have passed after revert OverAcquire, please continue to review, thank you.

wForget avatar Oct 30 '24 09:10 wForget

Run Gluten Clickhouse CI

zhztheplayer avatar Oct 30 '24 12:10 zhztheplayer

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 31 '24 02:10 github-actions[bot]

Hi @wForget , thank you for keeping working on this.

And I might forget that, have you picked https://github.com/apache/incubator-gluten/pull/7244? Which targeted to fix some hanging issues.

zhztheplayer avatar Nov 01 '24 06:11 zhztheplayer

Hi @wForget , thank you for keeping working on this.

And I might forget that, have you picked #7244? Which targeted to fix some hanging issues.

Thanks for your help, I will try pick #7244 later

wForget avatar Nov 01 '24 08:11 wForget

Run Gluten Clickhouse CI

github-actions[bot] avatar Nov 04 '24 05:11 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Nov 04 '24 09:11 github-actions[bot]

Could you please let me know if there are any issues with this PR that I should address?

kecookier avatar Nov 11 '24 02:11 kecookier

Could you please let me know if there are any issues with this PR that I should address?

There are still failed checks, do you have any ideas?

wForget avatar Nov 11 '24 02:11 wForget