Keenan Brock

Results 228 comments of Keenan Brock

update: - old version was a POC - removed blocks from supports :console, :html_console - (in child providers) webmks now linked to console (in addition to html_console) - only changed...

update: - missed the change to vm/operations. the tests were still green. concerning but assuming (hoping) the provider tests would have been red for those instead?

WIP: - this got too big - seems the concepts of the various supported are confusing NEXT STEPS: Go through the providers mentioned and copy validates logic into supports blocks....

issues were fixed by https://github.com/ManageIQ/manageiq-ui-classic/pull/8266 - it is no longer calling `supports_*?` So there is no reason for the `WIP`.

update: - rebased - this now contains only the supports_not removals

I goofed. see more at #22751

Dali also updated their session code to handle this case. (goldstein rocks) So in the future, we potentially can drop our custom code. I just never had a good test...

Does the API pr linked above meet our needs. is this done?

I need to bring this back to life

@fryguy there is a lot of 🔥 in this PR. Do we want to bring back to life?