manageiq
manageiq copied to clipboard
ManageIQ
Add ability to update VM description
We are using kasparov-2 and we are looking for a way to modify the description field of a VM without going through the GUI (
Sort of, VMware doesn't have a "description" exactly. They have a Notes field which the backend API calls "summary.config.annotations" [ref]. We parse this and store it in the vm.hardware.annotation column. It can be changed by issuing a ReconfigVM_Task API call.
Not clear to me why annotations are stored in hardware and not in Vm#description maybe @Fryguy remembers?
Not clear to me why annotations are stored in hardware and not in Vm#description maybe @Fryguy remembers?
Just seems plain wrong, but maybe we had a reason that made sense at the time?
Yeah agreed, unless we have some requirement that Vm#description can't have newlines I don't see why we wouldn't just use notes as the vm description
t.text "description", comment: "A description of the VM that is typically set by the provider, but may also be edited."
I would propose fixing our refresher to store the VM's description in the proper field.
The use case here is the following.
We are using MIQ in multi-tenant configuration.
Our customers would like to be able to add a description on their VMs in order to be able to identify them more easily in the interface. The ideal would be to display this description in the grid which lists the VMs. We have therefore considered using the currently available "description" field to do this. The problem is that editing this field using the "configuration / edit this VM" button allows other modifications to be made than just the description of the VM.
The idea is to create a customize button allowing you to modify only the description. Unfortunately it is not possible to modify the description by code. That's why I opened this issue.
Next, since the description field is not displayed in the grid when listing the VMs, we will provide our customers with a custom filter that will allow them to search for VMs whose description contains a string they will enter.
I'm not sure if using the description field is the best option to deal with this use case or if there is a cleanest way to do it.
All of the provider PRs are merged. I think we just need API/UI support at this point.
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.
We plan to upgrate to Oparin/Petrosian soon. We will this test this new feature and make you a feedback.
@jeffibm Do we have UI for this? I see that the API was completed, but I don't see any UI changes. If not, can we add this?
@jeffibm Do we have UI for this? I see that the API was completed, but I don't see any UI changes. If not, can we add this?
Based on the previous discussion, we will raise a PR that gives the ability to update just the description in another form by making use of this API - https://github.com/ManageIQ/manageiq-api/pull/1120 cc @kbrock
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.