manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard

[WIP] Remove MiqLdap

Open Fryguy opened this issue 3 years ago • 19 comments

WIP because I'm still finding tentacles, plus I still want to run cross-repo

Fixes #20017

Fryguy avatar Mar 26 '21 21:03 Fryguy

cc @jvlcek @chessbyte @bdunne

Fryguy avatar Mar 26 '21 21:03 Fryguy

Not sure what to do with these:

https://github.com/ManageIQ/manageiq/blob/0590341e394117fd2a2de706750ce56eb484fa38/tools/miq_config_sssd_ldap/configure_database.rb#L35-L40

Fryguy avatar Mar 26 '21 21:03 Fryguy

Also still trying to figure out if any settings can be dropped.

Fryguy avatar Mar 26 '21 22:03 Fryguy

Yay. I remember starting this removal 6 years ago with GM. so happy it is down to the last remains

I do seem to remember that these tests would only run on lucy's computer. So we had them mostly stubbed out except on an individual's computer that had ldap configured.

@jvlcek do you remember if ldap specs currently run in ci, or if they only run locally on a machine with ldap configured?

kbrock avatar Mar 30 '21 18:03 kbrock

Checked commit https://github.com/Fryguy/manageiq/commit/3908d53340564efdbe92da44e5511d41428c71da with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 9 files checked, 0 offenses detected Everything looks fine. :trophy:

miq-bot avatar Apr 16 '21 09:04 miq-bot

fwiw/ the failure is related to tools/miqldap_to_sssd/cli_convert.rb which was just deleted. I'm not sure if this tool is used for miq ldap, or used to help us configure external ldap

Is this PR going to also touch the ui? https://github.com/ManageIQ/manageiq-ui-classic/pull/7230#issuecomment-665048014

kbrock avatar May 11 '21 04:05 kbrock

The initial intent of this tool was to convert configurations from MiqLdap to external auth with SSSD for LDAP. However it can also be used to do initial configurations of external auth with SSSD for LDAP.

For example, the below could be run from the command line on a newly deployed appliance:

miq_config_sssd --domain="example.com" --bind-dn="cn=Manager,dc=example,dc=com" --bind-pwd="secret" --mode="ldap" --ldaphost="my-openldap.example.redhat.com" --ldap-role --user-type="dn-cn" --user-suffix="ou=people,ou=prod,dc=example,dc=com"

This could be integrated into the UI or the httpd_configmap_generator

jvlcek avatar May 11 '21 09:05 jvlcek

The initial intent of this tool was to convert configurations from MiqLdap [...] However it can also be used to do initial configurations of external auth

Seems like we want to keep that tool.

kbrock avatar May 26 '21 22:05 kbrock

Seems like we want to keep that tool.

Or move it inside appliance_console.

Fryguy avatar May 27 '21 22:05 Fryguy

This pull request is not mergeable. Please rebase and repush.

miq-bot avatar Nov 19 '21 15:11 miq-bot

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Feb 27 '23 00:02 miq-bot

I need to bring this back to life

kbrock avatar Mar 15 '23 00:03 kbrock

This pull request is not mergeable. Please rebase and repush.

miq-bot avatar Mar 15 '23 12:03 miq-bot

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Jun 19 '23 00:06 miq-bot

This pull request is not mergeable. Please rebase and repush.

miq-bot avatar Jun 19 '23 13:06 miq-bot

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Sep 25 '23 00:09 miq-bot

This pull request is not mergeable. Please rebase and repush.

miq-bot avatar Nov 08 '23 20:11 miq-bot

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot avatar Feb 12 '24 00:02 miq-bot