Kevin Anderson
Kevin Anderson
Could file size be reduced by omitting the ocean bathymetry data? I'm not really familiar with h5 files. If accuracy is not so important, maybe cutting the values down to...
I'm -1 to having `Location.get_solarposition()` make web requests, if that's being proposed. I'm cautiously open to bundling a local dataset if it's only a ~1MB expense (our [current dist](https://pypi.org/project/pvlib/#files) is...
I think I agree that it would make more sense to pass around ground albedo with the weather data instead of treating it as a characteristic of the array. >...
To clarify my above message, I think it *already* works to set `PVSystem.albedo` or `Array.albedo` to a Series, despite the docs saying it must be float. > are there other...
> Is there another solution I did not consider ? It is a bit clunky, but the general task of applying a function only vectorized across time to data with...
`ivtools` is another option. I think of `iotools` as functions to handle i/o of timeseries weather data specifically. Although I suppose `retrieve_sam` fetches inverter parameters as well, so `ivtools` isn't...
## Review checklist for @kanderso-nrel ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
Sorry for the delay; I have been occupied the last few weeks. I plan to take another look here soon. Feel free to ping me again if I have not...
@editorialbot generate pdf
Hi, just reporting in that I have mostly finished my review but ran into a problem that prevented me from going further (https://github.com/cire-thk/BifacialSimu/issues/21). The other issues I created are not...