Kevin Anderson
Kevin Anderson
> I think setuptools_scm by default include files checked in VCS. I think you're right, and we should adapt our MANIFEST.in accordingly: https://github.com/pypa/setuptools_scm#file-finders-hook-makes-most-of-manifestin-unnecessary It's fine by me to change the...
> @kanderso-nrel can you check building SPA C extension is still working ? Should not be a problem, setuptools build backend is still using setup.py under the hood. After building...
> I thought https://github.com/pvlib/pvlib-python/discussions/1486#discussioncomment-3085581 with this pattern. That would destroy my workflow. I *think* editable installs are only a problem if you ditch `setup.py` altogether (https://github.com/pypa/setuptools/issues/2816#issuecomment-1195451458), which is not the...
Ok, makes sense that switching from versioneer (run-time version determination) to setuptools_scm (install-time determination) would cause this issue. After some searching, it seems like people either just live with outdated...
Quibble: technically it is `Array.get_irradiance` (not `PVSystem.get_irradiance`) that calculates `dni_extra` if it is missing: https://github.com/pvlib/pvlib-python/blob/90013a5ce43611c43224b3a2f3ef72f54ad527af/pvlib/pvsystem.py#L1468-L1469 I think I also lean towards option 3. I think changing that condition to `dni_extra...
I just stumbled on this -- too late for this year I guess, but maybe next year: https://developers.google.com/season-of-docs
FYI the Divio link is now broken (but is still on [archive.org](https://web.archive.org/web/20170529181245/https://www.divio.com/en/blog/documentation/)). Here is an updated link that seems to have more detail than the original page did: https://documentation.divio.com/ I...
Superseded by #1468
Seems like several of those items apply to the other sky diffuse model docstrings as well. Also, does it make sense for the Loutzenhiser reference to be listed first? Seems...
I have a function for fetching daily precip and temp from that php endpoint. I just used the browser devtools to examine requests the webpage makes instead of trying to...