Kevin Anderson

Results 405 comments of Kevin Anderson

@cwhanse Just curious, do you see this PR getting wrapped up in the next few weeks? I have something I'd like to use it for but can go another way...

Looks like the `dulwich` dependency is the culprit. Per https://www.dulwich.io/docs/#supported-versions-of-python, they dropped support for python 2.7 starting in `0.20`. The [failed build](https://travis-ci.org/github/SunPower/PVMismatch/jobs/741997843#L385) installs `0.20.2` while the [last passing build](https://travis-ci.org/github/SunPower/PVMismatch/jobs/689364938#L460) installed...

Just chiming in to say I think this would close #124 :)

I admit I was rather put off by that code too, but your explanation makes sense. I suppose if `setSuns` is changed, its twin `setTemps` should as well. Do you...

Even though a more involved fix might be better overall, a very unintrusive option would be a new PVcell method that looks like this: ``` def clone(self): cloned = copy.copy(self)...

Sorry, should have been more clear. Copy is faster than instantiation, presumably because instantiation incurs the cost of all the numerical IV calculations but copying does not. Here are the...

@chetan201 FYI I still need to include the above cloning idea to get this PR ready to merge. I'll try to get to that in the next few days.

I think this is ready for review. Two comments: - For reasons I don't fully understand, some of the copies in `PVmodule.setSuns()` and `setTemps()` are needed to pass the test...

RdTools uses (will use?) [nbsphinx](https://nbsphinx.readthedocs.io/en/0.7.0/) to automatically integrate jupyter notebooks with sphinx docs, just FYI if you aren't familiar with that sphinx extension

Thanks for the pointer to `pyinstrument` -- that's a very nice little tool that I will put to use outside of pvfactors as well! I continue to find it difficult...