Kevin Anderson comments

Results 405 comments of


                                            Kevin Anderson

Fix2461

Thanks @OmarBahamida and all other contributors here!

[BUGFIX] Inconsistent naming of `[cross_]axis_tilt` / `[cross_]axis_slope`

@echedey-ls fyi -- it seems like this change needs more discussion and review before it's ready for merge, so I moved the milestone to v0.13.2.

Diffuse Self-Shading Example: Incorrect transposition of shading.sky_diffuse_passias

Thanks @kdebrab. I think more or less the same issue is described in #1825, do you agree? IMHO this deserves a note in the passias functions' docstrings. Could also consider...

Diffuse Self-Shading Example: Incorrect transposition of shading.sky_diffuse_passias

> I wanted to recommend the alternative use of bifacial.utils.vf_row_sky_2d_integ in the docstring of sky_diffuse_passias, but felt that that's basically equivalent to deprecating the method Deprecation implies that we intend...

Add polo-smm

I think all code changes identified in review have now been addressed. I'll plan to merge this PR tomorrow unless objections are voiced.

Add polo-smm

Many thanks to all reviewers here, and to @jesuspolo for sticking with the process!

Google Summer of Code: Floating PV

Thanks @IoannisSifnaios for the great contributions!

`spa_python` with `numba` fails with array input

I'm inclined to consider this a feature request rather than a bug report since `spa_python`'s docstring specifies that latitude and longitude are of type float (not array). Arrays being allowed...

`spa_python` with `numba` fails with array input

Another option in pvlib is `pvlib.solarposition.ephemeris`. I'd expect it to work with array input for lat/lon, although also coincidentally. A future version of pvlib may have even better alternatives.

stream_temperature_function

> Although this equation was created for estimating stream temperature, there are a number of publications that have used it for estimating the lakewater and seawater temperature (not sure if...