Kevin Anderson
Kevin Anderson
Hmm, the doc example is not ideal in that it's calling `display()` on a figure generated and already displayed in an earlier cell, which probably doesn't match typical usage (only...
Thanks @mgeier, maybe I should take a step back and outline my use case. What I want to be able to do is specify figure alt text as unobtrusively as...
Not sure why the checks aren't showing up for the latest commit; github's webhooks have been having issues this week, but githubstatus.com doesn't show anything amiss at the moment. Closing...
I guess this is ready for review. I'm still very confused about the missing rows. For example there's not a single Canadian Solar module in either of these two tables...
A merged file seems like the best outcome, but it might be difficult to achieve. See https://github.com/pvlib/pvlib-python/issues/761#issuecomment-527606811 and https://sam.nrel.gov/forum/forum-general/3779-missing-pv-modules-and-inverters.html When they open in a few hours I will call the...
`pvsystem.retrieve_sam` currently has no concept of different versions of the same table. Would we add dates to the accepted `name` values, e.g. `retrive_sam(name='cecmod-2021-12-01')`? Would `name='cecmod'` point to the new or...
I've added a `version` parameter to switch between the two versions. I've kept the version data files separate instead of stacking them into one table, in part because they don't...
[pv-terms](https://duramat.github.io/pv-terms/#solar-position) recommends `apparent_solar_zenith`. I have the sense that apparent zenith is the more useful quantity, which to me suggests that it might deserve the unqualified `solar_zenith`. We should also fix...
I wonder if geometric zenith even needs its own name if it's not commonly needed and is only very slightly different from refracted zenith. Maybe call both of them `solar_zenith`...
What about column names in returned dataframes? I don't see a reasonable way to detect usage of the old names in return values. Adding the new names alongside the old...