Kevin Anderson

Results 405 comments of Kevin Anderson

Following up on the above speculation, using Series 3/4 parameters results in much better agreement with the SAPM model: ![image](https://user-images.githubusercontent.com/57452607/113793755-451c1b80-9706-11eb-9546-bf0edd7c0fb1.png) Click to show source code (225 lines) ```python import pandas...

OK I merged master into this branch and did a bit of cleanup. Still need to write tests. @stephenjkaplan I hope you don't mind me pushing to your branch for...

I realized I never actually came back to this... looks like unit tests are the main missing piece of this PR. @cwhanse in #1080 you suggested implementing the model in...

FWIW here's a quick comparison with measured 1-minute Tmod data from the NIST ground array, plus the other transient models, showing that this Hayes implementation is right in there with...

My 2 cents: both runtime type checking and explicit broadcasting are things I'd be reluctant to add to pvlib, but if we did then it seems better to me for...

I've not yet done more than a quick skim of this code, so take these as general comments. > exclude mlfm_graphs.py from testing. RdTools has a plotting module. We decided...

Other than a brief mention on the [matlab comparison page](https://pvlib-python.readthedocs.io/en/stable/user_guide/comparison_pvlib_matlab.html#documentation) I don't think the notebooks in `docs/tutorials` have ever been integrated with the readthedocs sphinx pages. I usually forget those...

@cwhanse I suspect the windows test cancellations are because of a matplotlib window blocking the thread. Telling matplotlib to use non-interactive graphics by adding `matplotlib.use('agg')` to `conftest.py` seems to fix...

I comment not because I feel strongly or think my input is particularly useful here but because feedback was specifically requested :) Using a class seems a bit unnecessarily heavy...