PVMismatch icon indicating copy to clipboard operation
PVMismatch copied to clipboard

Fix bad units in call to pvlib.pvsystem.sapm

Open joseph-sch opened this issue 2 years ago • 3 comments

Should we add tests to this module? There is an assertion in example.py that fails without this fix, but it's not exactly a unit test.

joseph-sch avatar Apr 06 '22 14:04 joseph-sch

Just chiming in to say I think this would close #124 :)

kandersolar avatar Apr 06 '22 17:04 kandersolar

@mikofski and all, there does not seem to be a maintainer on the repository... pull requests are not being merged...

According to #152 from @chetan201, the maintainer on behalf of SunPower should now be @ahoffmanSPWR ([email protected] according to their profile) but I don't see any activity from them...

Any way we could get the PRs merged?

joseph-sch avatar Apr 14 '22 09:04 joseph-sch

Hi all - Thanks for the nudge here. I took over as admin after some personnel changes. Apologies for the delays. I'll take a look at these requests.

ahoffmanSPWR avatar Apr 14 '22 18:04 ahoffmanSPWR