Julien Wajsberg
Julien Wajsberg
From @ochameau, this is a diff he got from a modified Florian's script: https://perfht.ml/2UAR9X2 This is the base profile: https://perfht.ml/2UFTZtN and this is the profile for the regression about a...
#1575 will land soon and implements a first step: from 2 profile URLs, import 2 threads from 2 different profiles into one view. Once in this view everything happens as...
I don't think so, cf the 2 latest comments above :-) This is like a meta bug for more stuff around this topic. Until we plan to spend time on...
mstange's WIP patch is https://gist.github.com/mstange/b47c90a0b8171bc74db77b9b48482163 But greg had another idea to manage when to `replaceState` or `pushState`: ```javascript /** * Provide a simple mechanism to stop and start pushing on...
The replaceState bit is now already handled by the code in https://github.com/firefox-devtools/profiler/blob/b3143cfdd9f771fb63b00abeb8e638f2f43c2556/src/app-logic/url-handling.js#L69-L88 So the new code here will only need to use one of these functions: ```js withHistoryReplaceStateSync(function() { ......
As a note, we see the bundle size in the CI logs, at the step `yarn build-prod:quiet`. But this is quite not practical.
Reopening because I believe this is still something we need. It would give us more confidence when changing these complex typings as well as when upgrading flow. Some key things...
(related to #1055 too)
Interesting, this is indeed confusing. Do you think theresource should stay like this (the URL) rather than the full js file?
(idea came from a discussion with @fqueze)