Julien Wajsberg
Julien Wajsberg
A few sources of the jank have been removed in #5121, especially switching to the marker chart the second time is now near instant. But it's still slow to switch...
We could do some things such as: * package all modified prefs inside the profile data (and display them somewhere in our UI) * detect if devtools is open somewhere...
What markers are they reported in? Do you have an example profile to share?
I see, I think it's just the matter of adding the field `responseStatus` in https://github.com/firefox-devtools/profiler/blob/5c7515aa243e8b21de77e0434d9cc0f761e8bafd/src/profile-logic/marker-schema.js#L72-L80 i'd be happy to review such a patch
callgrind's format is described in https://valgrind.org/docs/manual/cl-format.html It sounds like a good idea to support this format because other tools might use it too.
Thanks for looking at this! Initially I was thinking about supporting the callgrind format because it might be an output format for other tools as well, so this provides more...
Thanks @dalehamel for the thoughtful comments that I didn't answer before. > In these examples, you can see that the first two show 30ms in the hovered frame, and in...
> > @ashishbhate is that something you'd be interested to do? In the context of this bug, we'd be happy with either the callgrind format or the protobuf-based pprof format....
Thanks for the good points! Selecting the right tab by default is indeed in our plan. I also like your feedback about using the tab titles, that's an interesting suggestion....
See https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v5.13.13#n8282