Julien Wajsberg

Results 512 comments of Julien Wajsberg

> It seems like if the file size of the perf.txt generated by `perf script` is larger than 500MB, Firefox profiler would report such error: `Error: Unserializing the profile failed:...

Are you loading as a file or as an url? Your idea of using `Response(blob).json()` is an interesting idea! It's worth trying. I was also wondering about using the new...

Can you give us a good way to generate such a profile with functiontrace? Especially do you have the python script or app or scenario that, when you use functiontrace...

Worth mentioning is this new API: https://developer.mozilla.org/en-US/docs/Web/API/TextDecoderStream It's not in Firefox ESR yet, so if we use it it would still be good to keep the old way of working...

A newish project I just found while working on something else: https://www.npmjs.com/package/json-stream-es Also https://github.com/worker-tools/json-stream

From #1553: Markus wrote PR #1065 that prototyped this out. See that PR for more information.

Updated code in speedscope: https://github.com/jlfwong/speedscope/blob/master/src/import/instruments.ts

Yeah, the current code is: https://github.com/devtools-html/perf.html/blob/9934bc950d25e5baf88ebb5179d5d5363288ff4e/src/components/shared/Backtrace.js#L42-L47 We currently use the funcTable to get the information in: https://github.com/devtools-html/perf.html/blob/9934bc950d25e5baf88ebb5179d5d5363288ff4e/src/profile-logic/profile-data.js#L1614-L1617

You can try this in the marker panel for example. The tooltips don't disappear when this boolean is set. It would be good to support this in the activity graph...

Ah interesting, this should happen somewhere in the function https://github.com/firefox-devtools/profiler/blob/6a8c668e51c24f697bd21a94f0b2e02767019e02/src/profile-logic/merge-compare.js#L1182. We're already doing something similar hardcoded for `CompositorScreenshot` markers, but here we need to look at the original markerSchema. The...