profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Misleading URL in "Collapse resource" context menu item

Open mstange opened this issue 2 years ago • 2 comments

Profile: https://share.firefox.dev/3XBbdcU

For JS code from the web, we create one "resource" for the entire origin, e.g. one resource for all URLs with the origin "https://abs.twimg.com". But in the context menu for collapsing a resource, it has the full URL, which is confusing.

Steps to reproduce:

  1. Go to https://share.firefox.dev/3XBbdcU
  2. Right-click one of the Twitter JS functions in the call tree.
  3. Notice how it says "Collapse https://abs.twimg.com/responsive-web/...", i.e. it contains the full URL.
  4. Click the menuitem.
  5. Notice how not just that one URL, but all functions from https://abs.twimg.com have been collapsed.

Instead, the context menu item should say "Collapse https://abs.twimg.com/" with the rest of the URL omitted.

┆Issue is synchronized with this Jira Task

mstange avatar Jun 28 '23 17:06 mstange

Interesting, this is indeed confusing. Do you think theresource should stay like this (the URL) rather than the full js file?

julienw avatar Jul 12 '23 11:07 julienw

I'd say the current behavior of making the entire "origin" one resource is good enough. I haven't anyone see ask for the ability to collapse an individual JS file.

mstange avatar Oct 11 '23 02:10 mstange