Julien Wajsberg

My understanding is that the title is generated here: https://github.com/docsifyjs/docsify/blob/54cc5f939b9499ae56604f589eef4e3f1c13cdc5/src/core/render/compiler.js#L210 As you see it's taken from `str` quite directly. But you'd like that it's taken from the `config` object instead....

I tried to debug, and I think the issue is that the 2 callbacks are called for each of the token: https://github.com/docsifyjs/docsify/blob/c49c39a4a2d6528ec27a314ab5fdc1e274af685f/src/core/render/embed.js#L75-L78 As a result, `done` here is called twice:...

I think I understood the dance with the incrementations: when the token has a url, then the process is asynchronous, so the condition is there to ensure that we call...

404 means "page not found", it doesn't mean "we got some error about a file not found". Koa doesn't know the context. Especially in this case it's a configuration error...

Yeah this is a breaking change, I totally agree with that. Note that this is alleviated by the fact that this behavior is documented nowhere. I had to look at...

I'm surprised that `adjustVisualProgressTimestamps` doesn't give NaN values instead of `undefined`...

Or maybe that's another issue? Here is my full output: ``` [2022-04-05 18:24:35] INFO: Running tests using Chrome - 3 iteration(s) [2022-04-05 18:24:35] INFO: Testing url https://profiler.firefox.com iteration 1 [2022-04-05...

I cloned the browsertime repository, ran `npm ci` on it, and then simply use this command: ``` $ bin/browsertime.js -b firefox --firefox.binaryPath /home/julien/firefox-nightly/firefox https://profiler.firefox.com [2022-04-01 14:38:46] INFO: Running tests using...

Yeah usually I have no problem running nodejs scripts :) I'm on a Debian Linux in case this helps, node v16.13.

I finally ran it (by mistake: I ran sudo before and forgot :) ) and so got the executed programs in my system logs: ``` Apr 1 17:25:19 torri sudo:...